about summary refs log tree commit diff
Commit message (Collapse)AuthorAge
* Hide debug prompt if buffer starts with /June McEnroe2020-02-12
|
* Only exit on errorneous nick during registrationJune McEnroe2020-02-12
|
* Add 378 to list of WHOIS responsesJune McEnroe2020-02-12
| | | | | It's the one (from freenode anyway) that tells you where you're connecting from.
* Implement source address selectionmultiplexd2020-02-13
| | | | | | This commit adds a '-S' command line option and a "bind" configuration file option to specify the source address to bind to when connecting to the IRC server.
* Add /listJune McEnroe2020-02-12
|
* Simplify transpose swapJune McEnroe2020-02-12
|
* Add C-t transposeJune McEnroe2020-02-12
| | | | Also in emacs, weechat.
* Add C-v and M-vJune McEnroe2020-02-12
| | | | | I figure there should be some way to scroll without keypad, and apparently this is what emacs offers...
* Allow for arguments to open/copy utilitiesJune McEnroe2020-02-12
|
* Handle RPL_AWAYJune McEnroe2020-02-12
|
* Support monochromatic terminalsJune McEnroe2020-02-11
| | | | Oops, division by zero!
* Add .gz to chroot-man scriptJune McEnroe2020-02-11
|
* Add -R restricted flagJune McEnroe2020-02-11
|
* Add chroot targetJune McEnroe2020-02-11
|
* Exit focus and paste modes on err exitJune McEnroe2020-02-11
|
* Add startup GPLv3 note and URLJune McEnroe2020-02-11
| | | | I am a degenerate.
* Make sure -D_GNU_SOURCE ends up in CFLAGS on LinuxJune McEnroe2020-02-11
|
* Add note about setting PKG_CONFIG_PATHJune McEnroe2020-02-11
|
* Rename query ID on nick changeJune McEnroe2020-02-11
|
* Call completeClear when closing a windowJune McEnroe2020-02-11
|
* Don't insert color codes for non-mentionsJune McEnroe2020-02-11
|
* Take first two words in colorMentionsJune McEnroe2020-02-11
| | | | | This lets phrases like "hi june" get colored, but still doesn't get carried away.
* Use time_t for save signatureJune McEnroe2020-02-11
| | | | | | | It's actually more likely to be 64-bit than size_t anyway, and it eliminates some helper functions. Also don't error when reading an empty save file.
* Set self.nick to * initiallyJune McEnroe2020-02-11
| | | | | | | Allows removing a bunch of checks that self.nick is set, and it's what the server usually calls you before registration. Never highlight notices as mentions.
* Define ColorCap instead of hardcoding 100June McEnroe2020-02-11
|
* Move hash to top of chat.hJune McEnroe2020-02-11
|
* Move base64 out of chat.hJune McEnroe2020-02-11
|
* Move XDG_SUBDIR out of chat.hJune McEnroe2020-02-11
|
* Fix whois idle unit calculationJune McEnroe2020-02-11
| | | | Rookie mistake.
* Cast towupper to wchar_tJune McEnroe2020-02-11
| | | | For some reason it takes and returns wint_t...
* Cast set but unused variables to voidJune McEnroe2020-02-11
|
* Declare strlcatJune McEnroe2020-02-11
|
* Check if VDSUSP existsJune McEnroe2020-02-11
|
* Fix completeReplace iterationJune McEnroe2020-02-11
|
* Use pkg(8) to configure on FreeBSDJune McEnroe2020-02-11
|
* Merge branch 'rewrite'June McEnroe2020-02-11
|\
| * Add INSTALLING section to READMEJune McEnroe2020-02-11
| |
| * Add READMEJune McEnroe2020-02-11
| | | | | | | | Still missing: build requirements and instructions.
| * Invalidate title on uiShowJune McEnroe2020-02-10
| |
| * Only write out title if it has changedJune McEnroe2020-02-10
| |
| * Only write out title on uiDrawJune McEnroe2020-02-10
| |
| * Manually raise SIGINT from C-cJune McEnroe2020-02-10
| | | | | | | | | | | | This allows it to still work, but makes C-z C-c insert the color code rather than exit, and in the future, will allow pasting in text with color codes.
| * Split on <> in colorMentionsJune McEnroe2020-02-10
| | | | | | | | | | | | This allows it to color the nick in the common case of pasting "<nick> something they said" into the chat. Technically it should color the brackets too but that would be too much work.
| * Replace alignment tabs with spaces in bufferListJune McEnroe2020-02-10
| |
| * Add C-o as alias of M-/June McEnroe2020-02-10
| | | | | | | | M-/ is from weechat. C-o is like in vim.
| * Only automatically switch to expected joinsJune McEnroe2020-02-10
| |
| * Delegate to commandPrivmsg from commandMsgJune McEnroe2020-02-10
| |
| * Synthesize a QUIT message to handle on exitJune McEnroe2020-02-10
| | | | | | | | So that the end of a saved buffer contains the self quit.
| * Factor out XDG base directory codeJune McEnroe2020-02-10
| | | | | | | | | | And add warnings to configOpen, since that's the only way to be accurate if a weird error occurs.
| * Leave a blank line after loaded bufferJune McEnroe2020-02-10
| |
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-12-20 11:45:58 +0000
loc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu