summary refs log tree commit diff
path: root/command.c (unfollow)
Commit message (Expand)Author
2021-01-28Add Repology links to READMEJune McEnroe
2021-01-28Add key bindings to chat.tmux.conf, nitsKlemens Nanni
2021-01-28Add 335 to WHOIS responsesJune McEnroe
2021-01-28Move threshold and mute indicators directly after numberJune McEnroe
2021-01-27Save window time display toggleJune McEnroe
2021-01-27Measure timestamp width using ncursesJune McEnroe
2021-01-27Change default timestamp format to %XJune McEnroe
2021-01-27Add toggleable display of timestampsJune McEnroe
2021-01-26Only list up until scroll position with M-lJune McEnroe
2021-01-26Preserve scroll position across reflowsJune McEnroe
2021-01-26Add numbers to buffer linesJune McEnroe
2021-01-26Rename and move scroll functions closer to where they are usedJune McEnroe
2021-01-26Factor out windowReflowJune McEnroe
2021-01-26Use Warm heat for replies to user-initiated commandsJune McEnroe
2021-01-26Clarify configuration path interpretationsJune McEnroe
2021-01-26Tighten up XDG base directory path handlingJune McEnroe
2021-01-26Expand the opening paragraph of the manualJune McEnroe
2021-01-25Disable notify in restricted modeJune McEnroe
2021-01-25Don't print timestamps for blank lines in bufferListJune McEnroe
2021-01-25Do not copy time to wrapped linesJune McEnroe
2021-01-25Add protocol coverage to non-features listJune McEnroe
2021-01-25Move mention of pledge(2) and unveil(2) to READMEJune McEnroe
2021-01-23Preserve order of filters when removingJune McEnroe
2021-01-23Fix /unignore commandJune McEnroe
2021-01-23Remove use of "%n" to appease de RaadtJune McEnroe
2021-01-23Drop filesystem access iff possibleKlemens Nanni
2021-01-23Drop exec capability iff restrictedKlemens Nanni
2021-01-23Drop network capability after ircConnect()Klemens Nanni
2021-01-23Call pledge(2) after unveil(2)Klemens Nanni
2021-01-23Separate kiosk mode from restrict modeJune McEnroe
2021-01-21Simplify windowUpdate loops and factor out windowTopJune McEnroe
2021-01-21Document that M-l shows timestampsJune McEnroe
2021-01-19Don't lose swapped window when navigating to current bufferJeremy O'Brien
2021-01-19Use Warm heat for manually inserted blank linesJune McEnroe
2021-01-18Add example tmux(1) configKlemens Nanni
2021-01-17Use Warm heat for blank lines 1.5June McEnroe
2021-01-16Add -I highlight option and /highlightJune McEnroe
2021-01-16Rename ignore code to filterJune McEnroe
2021-01-16Remove join/part/quit ignore exampleJune McEnroe
2021-01-16Save and load window visibility thresholdsJune McEnroe
2021-01-16Restore toggling ignore with M--June McEnroe
2021-01-16Generalize ignore toggling to visibility thresholdJune McEnroe
2021-01-11Save and load the URL ring in the save file 1.4June McEnroe
2021-01-11Don't pass nick to urlScan for MOTD and helpJune McEnroe
2021-01-10Check fprintf return values rather than ferrorJune McEnroe
2021-01-10Sandbox with unveil(2) on OpenBSD in restricted modeJune McEnroe
2021-01-10Print chain to stdout with -oJune McEnroe
2021-01-10Allow interspersing flags and config filesJune McEnroe
2021-01-10Move -o to a separate SYNOPSIS lineJune McEnroe
2021-01-10Exit immediately when using -oJune McEnroe
generated by cgit-pink 1.4.1 (git 2.36.1) at 2024-11-20 08:15:34 +0000
file is restored so that the shell can continue to execute. Reported-by: Martijn Dekker <martijn@inlv.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19eval: Reap zombies after built-in commands and functionsHerbert Xu Currently dash does not reap dead children after built-in commands or functions. This means that if you construct a loop consisting of solely built-in commands and functions, then zombies can hang around indefinitely. This patch fixes this by reaping when necessary after each built-in command and function. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19redir: Fix typo in noclobber codeHerbert Xu The noclobber code has a typo in it that causes it to fail. This patch fixes it. Reported-by: Denys Vlasenko <vda.linux@googlemail.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-19expand: Fix glibc glob(3) supportHerbert Xu It's been a while since we disabled glob(3) support by default. It appears to be working now, however, we have to change our code to detect the no-match case correctly. In particular, we need to test for GLOB_NOMAGIC | GLOB_NOCHECK instead of GLOB_MAGCHAR. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix buffer overflow in expandmetaHerbert Xu The native version of expandmeta allocates a buffer that may be overrun for two reasons. First of all the size is 1 byte too small but this is normally hidden because the minimum size is rounded up to 2048 bytes. Secondly, if the directory level is deep enough, any buffer can be overrun. This patch fixes both problems by calling realloc when necessary. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Move echo space/nl handling into print_escape_strHerbert Xu Currently echocmd uses print_escape_str to do everything apart from printing the spaces/newlines separating its arguments. This patch moves the actual printing into print_escape_str as well using the format parameter. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02builtin: Fix echo performance regressionHerbert Xu The commit d6c0e1e2ffbf7913ab69d51cc794d48d41c8fcb1 ("[BUILTIN] Handle embedded NULs correctly in printf") caused a performance regression in the echo built-in because every echo call now goes through the printf %b slow path where the string is always printed twice to ensure the space padding is correct in the presence of NUL characters. In fact this regression applies to printf %b as well. This is easily fixed by making printf %b take the fast path when no precision/field width modifiers are present. This patch also changes the second strchurnul call to strspn which generates slightly better code. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix ghost fields with unquoted $@/$*Herbert Xu Harald van Dijk <harald@gigawatt.nl> wrote: > On 22/03/2018 22:38, Martijn Dekker wrote: >> Op 22-03-18 om 20:28 schreef Harald van Dijk: >>> On 22/03/2018 03:40, Martijn Dekker wrote: >>>> This patch fixes the bug that, given no positional parameters, unquoted >>>> $@ and $* incorrectly generate one empty field (they should generate no >>>> fields). Apparently that was a side effect of the above. >>> >>> This seems weird though. If you want to remove the recording of empty >>> regions because they are pointless, then how does removing them fix a >>> bug? Doesn't this show that empty regions do have an effect? Perhaps >>> they're not supposed to have any effect, perhaps it's a specific >>> combination of empty regions and something else that triggers some bug, >>> and perhaps that combination can no longer occur with your patch. >> >> The latter is my guess, but I haven't had time to investigate it. > > Looking into it again: > > When IFS is set to an empty string, sepc is set to '\0' in varvalue(). > This then causes *quotedp to be set to true, meaning evalvar()'s quoted > variable is turned on. quoted is then passed to recordregion() as the > nulonly parameter. > > ifsp->nulonly has a bigger effect than merely selecting whether to use > $IFS or whether to only split on null bytes: in ifsbreakup(), nulonly > also causes string termination to be suppressed. That's correct: that > special treatment is required to preserve empty fields in "$@" > expansion. But it should *only* be used when $@ is quoted: ifsbreakup() > takes nulonly from the last IFS region, even if it's empty, so having an > additional zero-length region with nulonly enabled causes confusion. > > Passing quoted by value to varvalue() and not attempting to modify it > should therefore, and in my quick testing does, also work to fix the > original $@ bug. You're right. The proper fix to this is to ensure that nulonly is not set in varvalue for $*. It should only be set for $@ when it's inside double quotes. In fact there is another bug while we're playing with $@/$*. When IFS is set to a non-whitespace character such as :, $* outside quotes won't remove empty fields as it should. This patch fixes both problems. Reported-by: Martijn Dekker <martijn@inlv.org> Suggested-by: Harald van Dijk <harald@gigawatt.nl> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02parser: Allow newlines within parameter substitutionHerbert Xu On Fri, Mar 16, 2018 at 11:27:22AM +0800, Herbert Xu wrote: > On Thu, Mar 15, 2018 at 10:49:15PM +0100, Harald van Dijk wrote: > > > > Okay, it can be trivially modified to something that does work in other > > shells (even if it were actually executed), but gets rejected at parse time > > by dash: > > > > if false; then > > : ${$+ > > } > > fi > > That's just a bug in dash's parser with ${} in general, because > it bombs out without the if clause too: > > : ${$+ > } This patch fixes the parsing of newlines with parameter substitution. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-04-02expand: Fix bugs with words connected to the right of $@Herbert Xu On Sun, Mar 04, 2018 at 12:44:59PM +0100, Harald van Dijk wrote: > > command: set -- a ""; space=" "; printf "<%s>" "$@"$space > bash: <a><> > dash 0.5.8: <a>< > > dash 0.5.9.1: <a>< > > dash patched: <a><> This is actually composed of two bugs. First of all our tracking of quotemark is wrong so anything after "$@" becomes quoted. Once we fix that then the problem is that the first space character after "$@" is not recognised as an IFS. This patch fixes both. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-25Revert "[BUILTIN] Remove unnecessary restoration of format string in printf"Herbert Xu This reverts commit 7bb413255368e94395237d789f522891093c5774. The commit breaks printf with more than argument. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> 2018-03-22parser: Fix backquote support in here-document EOF markHerbert Xu