diff options
| author | June McEnroe <june@causal.agency> | 2022-09-18 22:08:40 -0400 |
|---|---|---|
| committer | June McEnroe <june@causal.agency> | 2022-09-18 22:08:40 -0400 |
| commit | 175f5eb14f9f3f48d3e3ed139603c5726949fac4 (patch) | |
| tree | 666c54ec67f599c48ca92656934b828d1ea86239 | |
| parent | Use | between equivalent options in manual (diff) | |
| download | imbox-master.tar.gz imbox-master.zip | |
| -rw-r--r-- | compat.c | 2 | ||||
| -rw-r--r-- | getservinfo.c | 2 | ||||
| -rw-r--r-- | git-fetch-email.1 | 2 | ||||
| -rw-r--r-- | git-fetch-emaHerbert Xu | |||||
| On Mon, Mar 26, 2018 at 07:25:20PM +0200, Martijn Dekker wrote: > Op 26-03-18 om 17:38 schreef Harald van Dijk: > > And not by dash 0.5.4. Like I wrote, dash 0.5.5 had some bugs that were > > fixed in 0.5.6, which mostly restored the behaviour to match <0.5.5. > > Ah, sorry. dash 0.5.4 and earlier don't compile on my system, so they > are not included in my conveniently accessible arsenal of test shells. > > > As for my patches, that was by accident and doesn't work reliably. When > > the shell sees no metacharacters, pathname expansion is bypassed, and > > backslash isn't considered a metacharacter. Which got me to my original > > example of /de\v: there are no metacharacters in there, so the shell > > doesn't look to see if it matches anything. Which seems highly > > desirable: the shell shouldn't need to hit the file system for words not > > containing metacharacters. The only way then to get consistent behaviour > > is if the backslash is taken as quoted, so I'm not tempted to argue for > > the behaviour you're hoping for, sorry. :) Here is a better example: a="/*/\nullx" b="/*/\null"; printf "%s\n" $a $b dash currently prints /*/\nullx /*/\null bash prints /*/\nullx /dev/null You may argue the bash behaviour is inconsistent but it actually makes sense. What happens is that quote removal only applies to the original token as seen by the shell. It is never applied to the result of parameter expansion. Now you may ask why on earth does the second line say "/dev/null" instead of "/dev/\null". Well that's because it is not the quote removal step that removed the backslash, but the pathname expansion. The fact that the /de\v does not become /dev even though it exists is just the result of the optimisation to avoid unnecessarily calling stat(2). I have checked POSIX and I don't see anything that forbids this behaviour. So going back to dash yes I think we should adopt the bash behaviour for pathname expansion and keep the existing case semantics. This patch does exactly that. Note that this patch does not work unless you have already applied https://patchwork.kernel.org/patch/10306507/ because otherwise the optimisation mentioned above does not get detected correctly and we will end up doing quote removal twice. This patch also updates expmeta to handle naked backslashes at the end of the pattern which is now possible. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> | ||||||
| 2018-04-19 | shell: Add subdir-objects to AM_INIT_AUTOMAKE | Jason Bowen | ||||
| I've attached a patch which adds the subdir-objects option to AM_INIT_AUTOMAKE. For a while now when I've compiled dash I received a warning from automake that there are source files in a subdirectory but that the subdir-objects automake option was not supplied. I've just been adding it myself, but I finally got around to submitting a patch. The code still compiles for now (i'm using automake 1.15.1), but warning text is rarely nice to see and, if the warning text is to be believed, then the warning will eventually become an error. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> | ||||||
| 2018-04-19 | eval: Restore input files in evalcommand | span> Send mail to diff --git a/git-fetch-email.sh b/git-fetch-email.sh index 574d04f..c992e4a 100644 --- a/git-fetch-email.sh +++ b/git-fetch-email.sh @@ -1,5 +1,5 @@ #!/bin/sh -# Copyright (C) 2019-2021 C. McEnroe <june@causal.agency> +# Copyright (C) 2019-2021 June McEnroe <june@causal.agency> # # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by diff --git a/imap.c b/imap.c index e875595..9cb5136 100644 --- a/imap.c +++ b/imap.c @@ -1,4 +1,4 @@ -/* Copyright (C) 2020 C. McEnroe <june@causal.agency> +/* Copyright (C) 2020 June McEnroe <june@causal.agency> * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/imap.h b/imap.h index d4cc927..001cad2 100644 --- a/imap.h +++ b/imap.h @@ -1,4 +1,4 @@ -/* Copyright (C) 2020 C. McEnroe <june@causal.agency> +/* Copyright (C) 2020 June McEnroe <june@causal.agency> * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by diff --git a/imbox.1 b/imbox.1 index abf0875..f87995c 100644 --- a/imbox.1 +++ b/imbox.1 @@ -173,7 +173,7 @@ imbox -T list+imbox@causal.agency june@causal.agency .El . .Sh AUTHORS -.An June Bug Aq Mt june@causal.agency +.An June McEnroe Aq Mt june@causal.agency . .Sh BUGS Send mail to diff --git a/imbox.c b/imbox.c index a4d34d7..ffe4a29 100644 --- a/imbox.c +++ b/imbox.c @@ -1,4 +1,4 @@ -/* Copyright (C) 2019-2021 C. McEnroe <june@causal.agency> +/* Copyright (C) 2019-2021 June McEnroe <june@causal.agency> * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by | ||||