summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2021-04-12 21:18:42 +0000
committerJune McEnroe <june@causal.agency>2021-04-12 21:21:56 +0000
commit2574f08695df0ac9271e177201b4faf2130ceb01 (patch)
tree6765564e6c5f9399ac1bcb6270368690950e190c
parentSimplify rfctags (diff)
downloadsrc-2574f08695df0ac9271e177201b4faf2130ceb01.tar.gz
src-2574f08695df0ac9271e177201b4faf2130ceb01.zip
Fix crash trying to print "this commit" on 404s
For example any URL that starts with a real repo name but isn't
valid.
-rw-r--r--www/git.causal.agency/cgit/ui-shared.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/www/git.causal.agency/cgit/ui-shared.c b/www/git.causal.agency/cgit/ui-shared.c
index d02b6c85..d7fa8b2a 100644
--- a/www/git.causal.agency/cgit/ui-shared.c
+++ b/www/git.causal.agency/cgit/ui-shared.c
@@ -896,7 +896,7 @@ void cgit_add_clone_urls(void (*fn)(const char *))
 static int print_this_commit_option(void)
 {
 	struct object_id oid;
-	if (get_oid(ctx.qry.head, &oid))
+	if (!ctx.qry.head || get_oid(ctx.qry.head, &oid))
 		return 1;
 	html_option(oid_to_hex(&oid), "this commit", ctx.qry.head);
 	return 0;