about summary refs log tree commit diff
diff options
context:
space:
mode:
authorJune McEnroe <june@causal.agency>2022-05-19 14:08:10 -0400
committerJune McEnroe <june@causal.agency>2022-05-19 14:08:10 -0400
commitef0baec389032b63cb47019f60f2817cc3b3024f (patch)
tree990736862b619136495c566fe1bdda8639252808
parentedit: Rename configs to over & under (diff)
downloadpounce-ef0baec389032b63cb47019f60f2817cc3b3024f.tar.gz
pounce-ef0baec389032b63cb47019f60f2817cc3b3024f.zip
Fix uninit read when checking if bindPath is a directory
-rw-r--r--bounce.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/bounce.c b/bounce.c
index 4146c0e..9ab0f1d 100644
--- a/bounce.c
+++ b/bounce.c
@@ -261,8 +261,9 @@ int main(int argc, char *argv[]) {
 	if (bindPath[0]) {
 		struct stat st;
 		int error = stat(bindPath, &st);
-		if (error && errno != ENOENT) err(EX_CANTCREAT, "%s", bindPath);
-		if (S_ISDIR(st.st_mode)) {
+		if (error) {
+			if (errno != ENOENT) err(EX_CANTCREAT, "%s", bindPath);
+		} else if (S_ISDIR(st.st_mode)) {
 			size_t len = strlen(bindPath);
 			snprintf(&bindPath[len], sizeof(bindPath) - len, "/%s", bindHost);
 		}